[CRIU] [PATCH] Makefile: move default goal up

Kir Kolyshkin kir at openvz.org
Wed Oct 5 12:08:17 PDT 2016


Since commit e6dcf46 there is no need to specify the default goal
explicitly.

The common convention for Makefiles is the first goal in the file
is the default one, so most universally there's "all:" goal
at the beginning. Let's adhere to this convention, moving
the "all:" up where it is to be expected.

[v2: keep the DEFAULT_GOAL for clarity]

Cc: Cyrill Gorcunov <gorcunov at openvz.org>
Signed-off-by: Kir Kolyshkin <kir at openvz.org>
---
 Makefile | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/Makefile b/Makefile
index c15132e..b840323 100644
--- a/Makefile
+++ b/Makefile
@@ -135,6 +135,10 @@ endif
 
 CFLAGS			+= $(WARNINGS) $(DEFINES)
 
+# Default target
+all: criu lib
+.PHONY: all
+
 #
 # Version headers.
 include Makefile.versions
@@ -239,9 +243,6 @@ lib: criu
 	$(Q) $(MAKE) -C lib all
 .PHONY: lib
 
-all: criu lib
-.PHONY: all
-
 subclean:
 	$(call msg-clean, criu)
 	$(Q) $(MAKE) -C lib clean
-- 
2.7.4



More information about the CRIU mailing list