[CRIU] [PATCH 1/3] Makefile: implicit default goal

Kir Kolyshkin kir at openvz.org
Tue Oct 4 18:58:51 PDT 2016


Since commit e6dcf46 there is no need to specify the default goal
explicitly. The common convention for Makefiles is the first goal
that is there is the default one, so most universally there's "all:"
goal somewhere at the beginning. Let's do the same thing, moving
the "all:" target up and removing the DEFAULT_GOAL.

Cc: Cyrill Gorcunov <gorcunov at openvz.org>
Signed-off-by: Kir Kolyshkin <kir at openvz.org>
---
 Makefile | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/Makefile b/Makefile
index c15132e..c975e4b 100644
--- a/Makefile
+++ b/Makefile
@@ -135,6 +135,10 @@ endif
 
 CFLAGS			+= $(WARNINGS) $(DEFINES)
 
+# Default target
+all: criu lib
+.PHONY: all
+
 #
 # Version headers.
 include Makefile.versions
@@ -239,9 +243,6 @@ lib: criu
 	$(Q) $(MAKE) -C lib all
 .PHONY: lib
 
-all: criu lib
-.PHONY: all
-
 subclean:
 	$(call msg-clean, criu)
 	$(Q) $(MAKE) -C lib clean
@@ -371,8 +372,6 @@ lint:
 
 include Makefile.install
 
-.DEFAULT_GOAL := all
-
 # Disable implicit rules in _this_ Makefile.
 .SUFFIXES:
 
-- 
2.7.4



More information about the CRIU mailing list