[CRIU] [PATCH v2 0/4] lazy-pages: improve testability

[Mike Rapoport]

On Mon, Nov 28, 2016 at 2:08 PM, Pavel Emelyanov <xemul at virtuozzo.com> wrote:
> Applied, thanks :)
>
> I have two questions:
>
> 1. How about adding the --remote-lazy-pages to criu-lazy-pages.sh?
>    Or have a separate job for this...

Let's ask the Jenkins guru. Andrei?

> 2. Patch #4:
>
>> @@ -932,7 +934,13 @@ class criu:
>>                       r_opts.append('mnt[zdtm]:%s' % criu_dir)
>>
>>               if self.__lazy_pages:
>> -                     self.__criu_act("lazy-pages", opts = ["--daemon", "--pidfile", "lp.pid"])
>> +                     lp_opts = ["--daemon", "--pidfile", "lp.pid"]
>> +                     if self.__remote_lazy_pages:
>> +                             lp_opts += ['--page-server', "--port", "12345"]
>> +                             ps_opts = ["--daemon", "--pidfile", "ps.pid",
>> +                                        "--port", "12345", "--lazy-pages"]
>> +                             self.__criu_act("page-server", opts = ps_opts)
>> +                     self.__criu_act("lazy-pages", opts = lp_opts)
>>                       r_opts += ["--lazy-pages"]
>>
>>               if self.__leave_stopped:
>
> You don't specify the address to where the lazy-pages daemon should connect, only
> the port. How does it work?

Don't know :) Magic?
Apparently, connect() with INADDR_ANY as saddr presumes localhost...

> -- Pavel



-- 
Sincerely yours,
Mike.