[CRIU] [PATCH 2/7] dedup, uffd: remove -1 handling for seep_pagemap_page return value

[Pavel Emelyanov]

On 11/22/2016 08:54 PM, Mike Rapoport wrote:
> On Tue, Nov 22, 2016 at 3:05 PM, Pavel Emelyanov <xemul at virtuozzo.com> wrote:
>>
>>> @@ -98,10 +98,8 @@ int dedup_one_iovec(struct page_read *pr, struct iovec *iov)
>>>               struct page_read * prp;
>>>
>>>               ret = pr->seek_page(pr, off, false);
>>> -             if (ret == -1)
>>> -                     return -1;
>>> -
>>>               if (ret == 0) {
>>> +                     pr_err("Missing %lx in parent pagemap\n", off);
>>
>> I've changed this to be pr_warn() as it's not an error actually :) and
>> also this killed travis builds (it works slow and generates lots of
>> error messages like this which are then grep-ed by zdtm.py and kill
>> the travis log capacity: https://travis-ci.org/xemul/criu/builds/177953269)
> 
> I won't mind killing it completely. Are we really interested in this message?

:D I really don't mind killing any message from CRIU as I can hardly remember
what was the last time I used them for debugging. Evey time a problem occurs
I add new. And only pr_err-s and pr_perrors give some glues...

-- Pavel