[CRIU] [PATCH 2/7] dedup, uffd: remove -1 handling for seep_pagemap_page return value

Pavel Emelyanov xemul at virtuozzo.com
Tue Nov 22 05:05:08 PST 2016


> @@ -98,10 +98,8 @@ int dedup_one_iovec(struct page_read *pr, struct iovec *iov)
>  		struct page_read * prp;
>  
>  		ret = pr->seek_page(pr, off, false);
> -		if (ret == -1)
> -			return -1;
> -
>  		if (ret == 0) {
> +			pr_err("Missing %lx in parent pagemap\n", off);

I've changed this to be pr_warn() as it's not an error actually :) and
also this killed travis builds (it works slow and generates lots of
error messages like this which are then grep-ed by zdtm.py and kill
the travis log capacity: https://travis-ci.org/xemul/criu/builds/177953269)

-- Pavel

>  			if (off < pr->cvaddr && pr->cvaddr < iov_end)
>  				off = pr->cvaddr;
>  			else
> diff --git a/criu/uffd.c b/criu/uffd.c



More information about the CRIU mailing list