[CRIU] [PATCH 0/3] Provide memcpy/memcmp/memset for pie/noglibc case

[Kir Kolyshkin]

On 11/17/2016 12:13 AM, Pavel Emelyanov wrote:
> On 11/17/2016 02:56 AM, Kir Kolyshkin wrote:
>> Any comments, or can this be applied? This is the last frontier for clang,
>> ie once merged CRIU is fully compilable with clang.
> There was a set titled "arm64 clang compile fixes" from which
> patches 3 and 4 hasn't been merged. Presumably patch is obsoleted
> by this set, but how about the 4th?

Patch 3, that provided asm memcpy for arm64, is not
strictly needed with this, but I intend to redo it and send later
(using a presumably better source for asm code).

Patch 4, will send separately later once I make sure it works.

> Also I must have missed the travis e-mail for this set, do we have
> it? Not that I doubt that you checked the build, it's just for
> us when resolving the failures to faster spot the patches that
> might have not been travis-checked.

Well, it looks like it got stuck in Travis so was never completed.

Patchwork: https://patchwork.criu.org/series/847/
Travis build: https://travis-ci.org/criupatchwork/criu/builds/174949951

Seems that a build on Alpine Linux was somehow stuck
(https://travis-ci.org/criupatchwork/criu/jobs/174949965).
Everything else, apparently, went fine.

I have also tested it on travis myself (with more patches in fact,
making sure that if we remove arch-specific mem* functions
everything works). Results are here:
https://travis-ci.org/kolyshkin/criu/builds/174634847

>
> -- Pavel
>
>> On 11/10/2016 04:32 PM, Kir Kolyshkin wrote:
>>> For those arches that does not have memcpy/memcmp/memset implemented,
>>> provide generic version of these, for code that is not linked to glibc,
>>> since compiler can generate calls to these functions.
>>>
>>> Kir Kolyshkin (3):
>>>     builtin_{memcpy,memset}: make compatible with libc
>>>     pie: provide memcpy/memcmp/memset for noglibc case
>>>     criu/pie/Makefile: disable FORTIFY_SOURCE
>>>
>>>    criu/include/asm-generic/string.h | 30 ++++++++++++++++++++++++++----
>>>    criu/pie/Makefile                 |  1 +
>>>    2 files changed, 27 insertions(+), 4 deletions(-)
>>>
>> .
>>