[CRIU] zdtm failure on latest criu-dev (Unable to lseek(SEEK_DATA))

[Adrian Reber]

On Wed, Nov 16, 2016 at 12:00:49PM -0800, Andrei Vagin wrote:
> On Wed, Nov 16, 2016 at 11:51 AM, Adrian Reber <adrian at lisas.de> wrote:
> > On Wed, Nov 16, 2016 at 10:47:42AM -0800, Andrei Vagin wrote:
> >> On Wed, Nov 16, 2016 at 06:22:44PM +0100, Adrian Reber wrote:
> >> > Current criu-dev checkout zdtm fails with:
> >> >
> >> > ======================== Run zdtm/static/pthread00 in h ========================
> >> > Start test
> >> > ./pthread00 --pidfile=pthread00.pid --outfile=pthread00.out
> >> > Run criu dump
> >> > =[log]=> dump/zdtm/static/pthread00/30/1/dump.log
> >> > ------------------------ grep Error ------------------------
> >> > (00.012899) Error (criu/shmem.c:646): Unable to lseek(SEEK_DATA): Invalid argument
> >>
> >> What kernl do you use?
> >
> > The latest RHEL7 kernel: 3.10.0-514.el7.x86_64
> >
> > Just two weeks ago all tests except static/sched_policy00 would work,
> > now I have to exclude at least
> >
> > -x zdtm/static/pthread00 -x zdtm/static/pthread01 -x zdtm/static/maps01
> > -x zdtm/static/maps00 -x zdtm/transition/maps008 -x zdtm/transition/shmem
> >
> > Replacing the kernel with a newer version let's those tests pass.
> 
> 
> SEEK_DATA is broken in RHEL.
> 
> You need to backport this patch too:
> commit 387aae6fdd737038e92d7bb40712bdf6dcb11945
> Author: Hugh Dickins <hughd at google.com>
> Date:   Sun Aug 4 11:30:25 2013 -0700
> 
>     tmpfs: fix SEEK_DATA/SEEK_HOLE regression
> 
>     Commit 46a1c2c7ae53 ("vfs: export lseek_execute() to modules") broke the
>     tmpfs SEEK_DATA/SEEK_HOLE implementation, because vfs_setpos() converts
>     the carefully prepared -ENXIO to -EINVAL.  Other filesystems avoid it in
>     error cases: do the same in tmpfs.
> 
>     Signed-off-by: Hugh Dickins <hughd at google.com>
>     Cc: Jie Liu <jeff.liu at oracle.com>
>     Cc: Al Viro <viro at zeniv.linux.org.uk>
>     Signed-off-by: Linus Torvalds <torvalds at linux-foundation.org>

Thanks, I will try to include this patch and retry.

		Adrian