[CRIU] [PATCH 09/11] zdtm: check sockets in the TCP_CLOSING state

Andrei Vagin avagin at openvz.org
Thu Nov 10 23:10:09 PST 2016


From: Andrey Vagin <avagin at openvz.org>

TCP_CLOSING both sides have shutdown but we still have
            data we have to finish sending

Signed-off-by: Andrei Vagin <avagin at virtuozzo.com>
---
 test/zdtm/static/Makefile                 |   3 +
 test/zdtm/static/socket-tcp-closing.c     | 233 ++++++++++++++++++++++++++++++
 test/zdtm/static/socket-tcp-closing.desc  |   1 +
 test/zdtm/static/socket-tcp6-closing.c    |   1 +
 test/zdtm/static/socket-tcp6-closing.desc |   1 +
 5 files changed, 239 insertions(+)
 create mode 100644 test/zdtm/static/socket-tcp-closing.c
 create mode 100644 test/zdtm/static/socket-tcp-closing.desc
 create mode 120000 test/zdtm/static/socket-tcp6-closing.c
 create mode 120000 test/zdtm/static/socket-tcp6-closing.desc

diff --git a/test/zdtm/static/Makefile b/test/zdtm/static/Makefile
index b83183e..3a0313b 100644
--- a/test/zdtm/static/Makefile
+++ b/test/zdtm/static/Makefile
@@ -81,6 +81,8 @@ TST_NOFILE	:=				\
 		socket-tcp6-close-wait		\
 		socket-tcp-last-ack		\
 		socket-tcp6-last-ack		\
+		socket-tcp-closing		\
+		socket-tcp6-closing		\
 		sock_opts00			\
 		sock_opts01			\
 		sk-unix-unconn			\
@@ -431,6 +433,7 @@ socket-tcp-close-wait:	override CFLAGS += -D ZDTM_TCP_CLOSE_WAIT
 socket-tcp6-close-wait:	override CFLAGS += -D ZDTM_TCP_CLOSE_WAIT -D ZDTM_IPV6
 socket-tcp-last-ack:	override CFLAGS += -D ZDTM_TCP_LAST_ACK
 socket-tcp6-last-ack:	override CFLAGS += -D ZDTM_TCP_LAST_ACK -D ZDTM_IPV6
+socket-tcp6-closing:	override CFLAGS += -D ZDTM_IPV6
 
 $(LIB):	force
 	$(Q) $(MAKE) -C $(LIBDIR)
diff --git a/test/zdtm/static/socket-tcp-closing.c b/test/zdtm/static/socket-tcp-closing.c
new file mode 100644
index 0000000..3cce553
--- /dev/null
+++ b/test/zdtm/static/socket-tcp-closing.c
@@ -0,0 +1,233 @@
+#include "zdtmtst.h"
+
+#ifdef ZDTM_IPV6
+#define ZDTM_FAMILY AF_INET6
+#else
+#define ZDTM_FAMILY AF_INET
+#endif
+
+const char *test_doc = "Check sockets in the TCP_CLOSING state\n";
+const char *test_author = "Andrey Vagin <avagin at parallels.com";
+
+#include <stdio.h>
+#include <sys/types.h>
+#include <unistd.h>
+#include <string.h>
+#include <errno.h>
+#include <stdlib.h>
+#include <signal.h>
+#include <fcntl.h>
+#include <sys/socket.h>
+#include <netinet/tcp.h>
+
+static int port = 8880;
+
+#define BUF_SIZE 4096
+
+int fill_sock_buf(int fd)
+{
+	int flags;
+	int size;
+	int ret;
+
+	flags = fcntl(fd, F_GETFL, 0);
+	if (flags == -1) {
+		pr_err("Can't get flags");
+		return -1;
+	}
+	if (fcntl(fd, F_SETFL, flags | O_NONBLOCK) == -1) {
+		pr_err("Can't set flags");
+		return -1;
+	}
+
+	size = 0;
+	while (1) {
+		char zdtm[] = "zdtm test packet";
+		ret = write(fd, zdtm, sizeof(zdtm));
+		if (ret == -1) {
+			if (errno == EAGAIN)
+				break;
+			pr_err("write");
+			return -1;
+		}
+		size += ret;
+	}
+
+	if (fcntl(fd, F_SETFL, flags) == -1) {
+		pr_err("Can't set flags");
+		return -1;
+	}
+
+	test_msg("snd_size = %d\n", size);
+
+	return size;
+}
+
+static int clean_sk_buf(int fd)
+{
+	int size, ret;
+	char buf[BUF_SIZE];
+
+	size = 0;
+	while (1) {
+		ret = read(fd, buf, sizeof(buf));
+		if (ret == -1) {
+			pr_err("read");
+			return -11;
+		}
+
+		if (ret == 0)
+			break;
+
+		size += ret;
+	}
+
+	test_msg("rcv_size = %d\n", size);
+
+	return size;
+}
+
+int main(int argc, char **argv)
+{
+	int fd, fd_s, ctl_fd;
+	pid_t extpid;
+	int pfd[2];
+	int ret, snd_size = 0, rcv_size = 0;
+
+#ifdef ZDTM_TCP_LOCAL
+	test_init(argc, argv);
+#endif
+
+	if (pipe(pfd)) {
+		pr_err("pipe() failed");
+		return 1;
+	}
+
+	extpid = fork();
+	if (extpid < 0) {
+		pr_err("fork() failed");
+		return 1;
+	} else if (extpid == 0) {
+		int size = 0;
+		char c;
+
+#ifndef ZDTM_TCP_LOCAL
+		test_ext_init(argc, argv);
+#endif
+
+		close(pfd[1]);
+		if (read(pfd[0], &port, sizeof(port)) != sizeof(port)) {
+			pr_err("Can't read port\n");
+			return 1;
+		}
+
+		fd = tcp_init_client(ZDTM_FAMILY, "127.0.0.1", port);
+		if (fd < 0)
+			return 1;
+
+		ctl_fd = tcp_init_client(ZDTM_FAMILY, "127.0.0.1", port);
+		if (fd < 0)
+			return 1;
+
+		size = fill_sock_buf(fd);
+		if (size <= 0)
+			return 1;
+
+		if (shutdown(fd, SHUT_WR) == -1) {
+			pr_err("shutdown");
+			return 1;
+		}
+
+		if (write(ctl_fd, &size, sizeof(size)) != sizeof(size)) {
+			pr_err("write");
+			return 1;
+		}
+
+		if (read(ctl_fd, &c, 1) != 0) {
+			pr_err("read");
+			return 1;
+		}
+
+		size = clean_sk_buf(fd);
+		if (size < 0)
+			return 1;
+
+		write(ctl_fd, &size, sizeof(size));
+		close(fd);
+
+		return 0;
+	}
+
+#ifndef ZDTM_TCP_LOCAL
+	test_init(argc, argv);
+#endif
+
+	if ((fd_s = tcp_init_server(ZDTM_FAMILY, &port)) < 0) {
+		pr_err("initializing server failed");
+		return 1;
+	}
+
+	close(pfd[0]);
+	if (write(pfd[1], &port, sizeof(port)) != sizeof(port)) {
+		pr_err("Can't send port");
+		return 1;
+	}
+	close(pfd[1]);
+
+	/*
+	 * parent is server of TCP connection
+	 */
+	fd = tcp_accept_server(fd_s);
+	if (fd < 0) {
+		pr_err("can't accept client connection %m");
+		return 1;
+	}
+
+	ctl_fd = tcp_accept_server(fd_s);
+	if (ctl_fd < 0) {
+		pr_err("can't accept client connection %m");
+		return 1;
+	}
+
+	snd_size = fill_sock_buf(fd);
+	if (snd_size <= 0)
+		return 1;
+
+	if (shutdown(fd, SHUT_WR) == -1) {
+		pr_err("shutdown");
+		return 1;
+	}
+
+	if (read(ctl_fd, &ret, sizeof(ret)) != sizeof(ret)) {
+		pr_err("read");
+		return 1;
+	}
+
+	rcv_size = clean_sk_buf(fd);
+
+	if (ret != rcv_size) {
+		fail("The child sent %d bytes, but the parent received %d bytes\n", ret, rcv_size);
+		return 1;
+	}
+
+	test_daemon();
+	test_waitsig();
+
+	if (shutdown(ctl_fd, SHUT_WR) == -1) {
+		pr_err("shutdown");
+		return 1;
+	}
+
+	if (read(ctl_fd, &ret, sizeof(ret)) != sizeof(ret)) {
+		pr_err("read");
+		return 1;
+	}
+
+	if (ret != snd_size) {
+		fail("The parent sent %d bytes, but the child received %d bytes\n", snd_size, ret);
+		return 1;
+	}
+
+	pass();
+	return 0;
+}
diff --git a/test/zdtm/static/socket-tcp-closing.desc b/test/zdtm/static/socket-tcp-closing.desc
new file mode 100644
index 0000000..a0ff359
--- /dev/null
+++ b/test/zdtm/static/socket-tcp-closing.desc
@@ -0,0 +1 @@
+{'flavor': 'h', 'opts': '--tcp-established', 'flags': 'nouser samens', 'feature' : 'tcp_half_closed'}
diff --git a/test/zdtm/static/socket-tcp6-closing.c b/test/zdtm/static/socket-tcp6-closing.c
new file mode 120000
index 0000000..154ef8b
--- /dev/null
+++ b/test/zdtm/static/socket-tcp6-closing.c
@@ -0,0 +1 @@
+socket-tcp-closing.c
\ No newline at end of file
diff --git a/test/zdtm/static/socket-tcp6-closing.desc b/test/zdtm/static/socket-tcp6-closing.desc
new file mode 120000
index 0000000..63046e2
--- /dev/null
+++ b/test/zdtm/static/socket-tcp6-closing.desc
@@ -0,0 +1 @@
+socket-tcp-closing.desc
\ No newline at end of file
-- 
2.7.4



More information about the CRIU mailing list