[CRIU] [PATCH 3/4] arm64: provide own memcpy for pie

Cyrill Gorcunov gorcunov at gmail.com
Thu Nov 10 04:20:46 PST 2016


On Thu, Nov 10, 2016 at 03:11:59PM +0300, Dmitry Safonov wrote:
> 
> Ok, so you think, it's better to provide optimized code for arm/aarch64
> - then I suggest to do it on the top of those 3 patches:
> so that would be easy to turn off, if we spot some problem with optimized
> versions by undefining HAS_BUILTIN_*.
> 
> Otherwise, if we don't have those three patches, generic version would
> not make sence, as we have arch-optimized versions for each supported
> platform and generic version doesn't work in some circumstances (with
> clang currently).
> 
> So, there are two ways:
> 1. to remove completely generic version (as we have per-arch optimized)
> 2. to leave generic version working - if we spot any problem with
> optimized versions or will need to add a new platform.
> 
> I suggest to do (2), while it does mean that we'll have generic version
> always undefined - which means that we keep it as dead-code, but still
> that's just a for-loop and I prefer to do this.
> 
> Cyrill, what do you think?

vote for (2)


More information about the CRIU mailing list