[CRIU] libsoccr debug/info messages

Dmitry Safonov 0x7f454c46 at gmail.com
Thu Nov 10 03:30:20 PST 2016


2016-11-10 12:30 GMT+03:00 Adrian Reber <adrian at lisas.de>:
> On Wed, Nov 09, 2016 at 06:58:19PM +0300, Dmitry Safonov wrote:
>> 2016-11-09 16:37 GMT+03:00 Adrian Reber <adrian at lisas.de>:
>> > I see none of the loge/logd messages from libsoccr. It seems the logging
>> > is not initialized. Are there already patches which enable libsoccr
>> > logging?
>>
>> Hi Adrian,
>>
>> Looks like, it was forgotten.
>> Will an attached patch work for you?
>
> Thanks for the patch. Almost perfect. There is, however, somehow a
> new-line missing:
>
> (00.007955)  19239: Can't restore 2 queue data (-1), want (1022:65468:1022)(00.008009) Error (criu/cr-restore.c:2003): Restoring FAILED.
>
> There seems to be some inconsistency in soccr. Some loge/logd are
> without '\n'. Some include it. See attached patch for a fix.

Good, thanks for catching.
The other way would be - to define logd/loge macros with '\n' ending.
But I don't have any preference on that,
Reviewed-by: Dmitry Safonov <dsafonov at virtuozzo.com>


More information about the CRIU mailing list