[CRIU] [PATCH] zdtm/netns-dev: restrict hop_limit sysctl setting to range [1; 255]

[Pavel Tikhomirov]

Sorry, I missed the list first time, please see inline comment below.


Best Regards, Tikhomirov Pavel.

2016-05-24 23:30 GMT+03:00 Andrey Vagin <avagin at openvz.org>:

> From: Andrew Vagin <avagin at virtuozzo.com>
>
> $ git log v4.4-rc1-465-gd6df198
> commit d6df198d924775e4751561cf60ef0294e95f74df
> Author: Phil Sutter <phil at nwl.cc>
> Date:   Tue Dec 1 22:45:15 2015 +0100
>
>     net: ipv6: restrict hop_limit sysctl setting to range [1; 255]
>
>     Setting a value bigger than 255 resulted in using only the lower eight
>     bits of that value as it is assigned to the u8 header field. To avoid
>     this unexpected result, reject such values.
>
> https://github.com/xemul/criu/issues/164
> Signed-off-by: Andrew Vagin <avagin at virtuozzo.com>
> ---
>  test/zdtm/static/netns-dev.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/test/zdtm/static/netns-dev.c b/test/zdtm/static/netns-dev.c
> index 37b7b04..30b7f6a 100644
> --- a/test/zdtm/static/netns-dev.c
> +++ b/test/zdtm/static/netns-dev.c
> @@ -156,7 +156,7 @@ struct range rand_range6[] = {
>         {0, 2}, /* force_mld_version */
>         {0, 1}, /* force_tllao */
>         {0, 1}, /* forwarding */
> -       {0, INT_MAX},   /* hop_limit */
> +       {0, 255},       /* hop_limit */
>

May be we need {1, 255} here?


>         {0, 1}, /* ignore_routes_with_linkdown */
>         {-1, 1},        /* keep_addr_on_down */
>         {0, MAX_ADDRESSES},     /* max_addresses */
> --
> 2.7.4
>
> _______________________________________________
> CRIU mailing list
> CRIU at openvz.org
> https://lists.openvz.org/mailman/listinfo/criu
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openvz.org/pipermail/criu/attachments/20160525/1a60e29e/attachment.html>