[CRIU] [PATCH 1/2] add a tracefs test

[Tycho Andersen]

On Mon, May 23, 2016 at 04:48:06PM -0700, Andrei Vagin wrote:
> On Mon, May 23, 2016 at 4:34 PM, Tycho Andersen
> <tycho.andersen at canonical.com> wrote:
> > On Mon, May 23, 2016 at 04:16:26PM -0700, Andrew Vagin wrote:
> >> You again committed patches with failed tests...
> >
> > Like I said in the other thread, I think it only fails in the way you
> > said when you don't already have tracefs mounted. It passed for me
> > when I ran it :). Anyway, sorry about that, your patch looks good,
> > thanks.
> 
> On my host tracefs is mounted, but the test fails.

Hmm, ok. Maybe I'm misunderstanding the source of the bug, then. I
have to go for today, but I'll take a look tomorrow morning.

> I wrote this message, because if the main repo is broken, we can't
> validate patches.

Yep, sorry about that.

Tycho

> I don't want to say that you did something wrong. We all use
> different environments and can skip some bugs. It's normal.
> 
> [root at fc22-vm criu]# cat /proc/self/mountinfo | grep trace
> 107 35 0:9 / /sys/kernel/debug/tracing rw,relatime shared:61 - tracefs
> tracefs rw
> [root at fc22-vm criu]# python test/zdtm.py run -T zdtm/static/mnt_tracefs
> Checking feature mnt_id
> === Run 1/1 ================
> 
> ====================== Run zdtm/static/mnt_tracefs in uns ======================
> cc -g -O2 -Wall -Werror -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=0  -iquote
> ../lib/arch/x86/include -I../lib  -c -o mnt_tracefs.o mnt_tracefs.c
> cc   mnt_tracefs.o ../lib/libzdtmtst.a   -o mnt_tracefs
> Start test
> ./mnt_tracefs --pidfile=mnt_tracefs.pid --outfile=mnt_tracefs.out
> --dirname=mnt_tracefs.test
> Run criu dump
> Wait for zdtm/static/mnt_tracefs to die for 0.100000
> Run criu restore
> 1: Old mounts lost: set([])
> 1: New mounts appeared: set([('/', '/debugfs/tracing')])
> ############# Test zdtm/static/mnt_tracefs FAIL at mounts compare ##############
> Wait for zdtm/static/mnt_tracefs to die for 0.100000
> ##################################### FAIL #####################################
> 
> 
> >
> > Tycho
> >
> >> On Mon, May 23, 2016 at 08:02:41PM +0300, Pavel Emelyanov wrote:
> >> > Both applied, thanks
> >> > _______________________________________________
> >> > CRIU mailing list
> >> > CRIU at openvz.org
> >> > https://lists.openvz.org/mailman/listinfo/criu
> > _______________________________________________
> > CRIU mailing list
> > CRIU at openvz.org
> > https://lists.openvz.org/mailman/listinfo/criu