[CRIU] [PATCH] crit: merge criu-coredump

[Ruslan Kuprieiev]

Ok, sounds good to me.

Thanks


On 05/20/2016 02:25 PM, Pavel Emelyanov wrote:
> On 05/17/2016 10:07 PM, Ruslan Kuprieiev wrote:
>> Oh, one more thing.
>>
>> Are you okay with including coredump classes and methods into
>> pycriu(i.e. import pycriu.coredump)?
>>
>> crit-coredump script is definitely moving into a separate script, but
>> how about leaving related python helpers and classes(which are
>> independent from script itself, which just provides cli)? This is
>> similar to pycriu having crit classes and methods in pycriu.images and
>> pycriu.coredump should fit right in.
> Hm... I'd prefer seeing it as a standalone "sub-project" if you don't mind :)
>
>> Thanks
>>
>> On 05/16/2016 05:41 PM, Ruslan Kuprieiev wrote:
>>> Hi Pavel,
>>>
>>> Sounds good to me. There is nothing required from crit/pycriu that
>>> they don't
>>> provide already. I'll hopefully send new patch shortly.
>>>
>>> Thanks,
>>> Ruslan
>>>
>>> On 05/16/2016 04:29 PM, Pavel Emelyanov wrote:
>>>> On 05/06/2016 10:09 PM, Ruslan Kuprieiev wrote:
>>>>> It was originally developed as a "crit coredump" action, but it
>>>>> was decided to move it into a separate project about a year ago.
>>>>> Several month ago there was a discussion about moving it back to
>>>>> criu repo, so here is a patch to consider.
>>>> I don't mind, all the more so we've prepared criu source tree to contain
>>>> several "subprojects", but can you reshuffle the scripts not to be
>>>> the part of crit? Instead -- a root directory in criu itself or a
>>>> subdir in crit/ with separate cmdline would be better.
>>>>
>>>> If anyhting is required from crit/pycriu, they it would be OK to patch
>>>> them to provide necessary API.
>>>>
>>>> -- Pavel
>> .
>>