[CRIU] [PATCH 3/4] cg: Add ability to dump specified controllers only

[Pavel Emelyanov]

On 05/17/2016 02:57 PM, Cyrill Gorcunov wrote:
> On Tue, May 17, 2016 at 02:52:19PM +0300, Pavel Emelyanov wrote:
>> On 05/16/2016 04:27 PM, Cyrill Gorcunov wrote:
>>> On Mon, May 16, 2016 at 04:08:11PM +0300, Cyrill Gorcunov wrote:
>>>>>
>>>>> Isn't --cgroup-props freeser:none equals to --cgroup-dump-controller mem,cpu,<everything-else>?
>>>>> From my perspective former CLI would be shorter ;)
>>>>
>>>> Well, agreed. I'll have to rework the patch then. Drop it,
>>>> will do new one.
>>>
>>> Note though there is significant problem with this approach -- the name of
>>> cgroup may be dynamic (say name=xxx) and at moment of dump we simply
>>> may don't know it. So we need to specify only controllers to be carried
>>> into the image. Maybe something like --cgroup-props freezer:built-in
>>> and such?
>>
>> But you know the names of those "to be included" guys, what's bad with
>> finding out the "to be excluded" list?
> 
> The names of to be included are know from kernel config. In turn
> the rest is dynamic, new cgroups may be mounted on the node at
> any moment and instead of parsing cgroups twise we can simply
> pass "known cgroups" into criu arguments via script once.

Hm... So you effectively want criu not to do anything with unknown
controllers, don' you? Maybe it's better to add _this_ option?