[CRIU] implementing some kind of --leave-frozen option for c/r in CRIU
Tycho Andersen
tycho.andersen at canonical.com
Mon May 16 10:55:36 PDT 2016
On Mon, May 16, 2016 at 08:47:26PM +0300, Batalov Eugene wrote:
> Conceptually we're able to get the same state in criu gc as criu restore
> gets.
>
> I am agree about namespaces and network unlock. Our folk has missed this.
>
> About link remaps and namespaces. This thing from patch looks like it
> should working:
>
> > + if (rfe->remap_type == REMAP_TYPE__LINKED) {
> > + if (open_remap_linked(rfi, rfe))
> > + {
> > + pr_err("open_remap_linked failed");
> > + return -1;
> > + }
> > +
> > + int mntns_root = mntns_get_root_by_mnt_id(rfi->remap->rmnt_id);
Perhaps I'm missing something, but why is this mntns the same one as
the task whose mount ns we're trying to clean?
I can see that it might work because you pivot_root() into the same
--root as the dump/restore is in, but if the container's root isn't
mounted on the host won't that fail?
Tycho
More information about the CRIU
mailing list