[CRIU] [PATCH 3/4] cg: Add ability to dump specified controllers only

[Cyrill Gorcunov]

On Mon, May 16, 2016 at 04:04:12PM +0300, Pavel Emelyanov wrote:
> On 05/16/2016 03:53 PM, Cyrill Gorcunov wrote:
> > On Mon, May 16, 2016 at 03:39:48PM +0300, Pavel Emelyanov wrote:
> >>> @@ -631,6 +632,10 @@ int main(int argc, char *argv[], char *envp[])
> >>>  		case 1081:
> >>>  			opts.cgroup_props_file = optarg;
> >>>  			break;
> >>> +		case 1082:
> >>> +			if (!cgp_add_dump_controller(optarg))
> >>
> >> Why not rely on --cgroup-props[-file] option?
> >>
> >>> +				return 1;
> >>> +			break;
> > 
> > This is different. This particular feature allows us to skip
> > controllers without specifying properties, ie when we're fine
> > with built-in props criu provides. This saves space in command
> > line arguments.
> 
> Isn't --cgroup-props freeser:none equals to --cgroup-dump-controller mem,cpu,<everything-else>?
> From my perspective former CLI would be shorter ;)

Well, agreed. I'll have to rework the patch then. Drop it,
will do new one.