[CRIU] [PATCH 1/4] cg: Add ability to dump custom cgroup properties

Cyrill Gorcunov gorcunov at gmail.com
Fri May 13 14:32:14 PDT 2016


On Fri, May 13, 2016 at 03:28:08PM -0600, Tycho Andersen wrote:
> On Fri, May 13, 2016 at 11:03:43PM +0300, Cyrill Gorcunov wrote:
> > +static int cgp_parse_builtins(void)
> > +{
> > +	static const char predefined_stream[] =
> ...
> > +
> > +	return cgp_parse_stream((void *)predefined_stream,
> > +				strlen(predefined_stream));
> 
> Minor nit here, but it would be handy if we didn't have to cast this
> to void to work around const. Can we just declare it non-const if
> fixing all the functions won't work?

Yeah. Pavel could you please drop const when merging (once
I have it tested properly, i'll ping once I do).


More information about the CRIU mailing list