[CRIU] [PATCH 1/2] tty: Add missing break statement

Dmitry Safonov dsafonov at virtuozzo.com
Wed May 11 09:48:24 PDT 2016


On 05/11/2016 07:47 PM, Cyrill Gorcunov wrote:
> On Wed, May 11, 2016 at 07:24:10PM +0300, Dmitry Safonov wrote:
>>>
>>> qemu may have simple emulated uart device (just like we've
>>> had in lkvm), so that plain open/read/write on it works
>>> just fine. but it not always the true, there might be
>>> exceptions and every driver should be investigated seperately.
>>
>> Ok, so, that seems there is no point omitting break here.
>> As UART devices needs some dances that's pointless.
>
> Yes, we need to look into every serial device we're going to
> support if we can c/r it without problem. Thus 'break' prevent
> us from potential problems.

Thanks for explanations,
Reviewed-by: Dmitry Safonov <dsafonov at virtuozzo.com>



More information about the CRIU mailing list