[CRIU] [PATCH 1/2] tty: Add missing break statement

Dmitry Safonov dsafonov at virtuozzo.com
Wed May 11 09:24:10 PDT 2016


On 05/11/2016 07:01 PM, Cyrill Gorcunov wrote:
> On Wed, May 11, 2016 at 06:53:52PM +0300, Dmitry Safonov wrote:
>> On 05/11/2016 06:44 PM, Cyrill Gorcunov wrote:
>>>
>>> Then it's an error -- we should provide VT driver
>>> for VT terminals only :/
>>>
>>> Moreover UART serieal devices (at least for hardware
>>> parts I've been working with) require a way more than
>>> just plain open() over them to make them work properly
>>> after restore.
>>
>> Hmm, I remember I tested it with qemu-system-aarch64 and rpi2 box,
>> attached with USB-to-serial converter. Currently, can't remember,
>> did Raspbeery see it as ttyS0 or ttyAMA0.
>> Qemu, as I wrote in commit, looks through ttyAMA0 serial.
>
> qemu may have simple emulated uart device (just like we've
> had in lkvm), so that plain open/read/write on it works
> just fine. but it not always the true, there might be
> exceptions and every driver should be investigated seperately.

Ok, so, that seems there is no point omitting break here.
As UART devices needs some dances that's pointless.


More information about the CRIU mailing list