[CRIU] [PATCH 1/4] cg: Add ability to dump custom cgroup properties

[Pavel Emelyanov]

On 05/06/2016 04:32 PM, Cyrill Gorcunov wrote:
> On Fri, May 06, 2016 at 04:15:58PM +0300, Pavel Emelyanov wrote:
>>>>
>>>> It will be hard to do it on top. Once we move the list of props to work on
>>>> into separate file we can give up using the --cgroup-props option. Actually
>>>> we can give up with the --cgroup-props-file option too by suggesting to
>>>> replace the file itself :)
>>>>
>>>> So my current concern is more about the API extension you propose.
>>>
>>> In which format we gonna keep it there? Yaml too?
>>
>> Yes. The same format that you propose for custom file.
> 
> OK
> 
>>
>>> No, I think having these options is a win,
>>> hardcoded place is never a good option.
>>
>> Tons of software keep configuration in "hardcoded" places.
> 
> Which doesn't make it anyhow better if there is no way to
> re-define this place. What if you run criu without filesystem
> at all?

Where do I get criu itself from then? ;)

> We might endup is some network backend which would save
> images directly on server side/cloud, moreover there might be
> no /etc and such on the machine at all. Yes, I know about LFS
> and other standarts, but still.
> 
> For vz7 we will need command line options (ie cgroup-props
> and cgroup-props-file) because it's convenient to test such
> things via cli patching libvzctl scripts.
> 
> Btw, what is the better place for this "cgroup.yaml" file
> we gonna use as default one?

I don't know. Maybe Tycho can suggest something? Does LX[CD] have
some list of default parameters for cgroups and, if it does, where
does it keep it?

-- Pavel