[CRIU] [PATCH] criu: tty -- Restore tty params synchronously

Cyrill Gorcunov gorcunov at virtuozzo.com
Wed May 4 07:52:39 PDT 2016


On Wed, May 04, 2016 at 05:39:37PM +0300, Pavel Emelyanov wrote:
> >>> now pty_open_unpaired_slave will close the master but then in-flight
> >>> request may start and will exit with error.
> >>
> >> Still, send_fd_to_peer() failed and we exit with error anyway.
> > 
> > It doesn't matter. It's bloody wrong calling the function which
> > _implies_ that tty is alive on dead tty. That's the point.
> 
> If (!) this is done on error paths, then it's ... affordable. Doing
> synchronous usernsd calls is worse.

OK, up to you.


More information about the CRIU mailing list