[CRIU] [PATCH] parasite/mem: unprotect VMAs if page dumping failed

[Dmitry Safonov]

On 03/29/2016 02:13 PM, Pavel Emelyanov wrote:
> On 03/28/2016 10:38 PM, Dmitry Safonov wrote:
>> Before patch parasite_dump_pages_seized tried to unprotect pages
>> by parasite command. But it had two issues:
>> 1. parasite doesn't wait any command, except PARASITE_CMD_FINI after
>>     it failed;
> But that's OK. The fini() call first unprotects vmas back, doesn't it?
Yes, you right - was confused by reject message and didn't check
fini for cleanup.
>
>> 2. return code for parasite_dump_pages_seized was not set according
>>     to __parasite_dump_pages_seized failure.
>   
>          ret = __parasite_dump_pages_seized(ctl, pargs, vma_area_list, pp);
>          if (ret)
>                  pr_err("Can't dump page with parasite\n");
>
> isn't this error setting? Why not?
>
Yes, drop this patch - have not gave it as much attentiveness,
as should. Sorry for the noise.

-- 
Regards,
Dmitry Safonov