[CRIU] [PATCH 4/9] nmk: build.mk -- Make process depend on Makefile itself

Pavel Emelyanov xemul at virtuozzo.com
Wed Mar 23 04:42:21 PDT 2016


On 03/21/2016 03:56 PM, Cyrill Gorcunov wrote:
> On Mon, Mar 21, 2016 at 03:53:50PM +0300, Dmitry Safonov wrote:
>>> -include $(call objectify,$(makefile))
>>> +src-makefile	:= $(call objectify,$(makefile))
>>> +include $(src-makefile)
>>>  ifneq ($(strip $(target)),)
>>>  	target := $(sort $(call uniq,$(target)))
>>> @@ -46,6 +47,16 @@ builtin-name	:= $(strip $(builtin-name))
>>>  ld_flags	:= $(strip $(LDFLAGS) $(ldflags-y))
>>>  #
>>> +# $(obj) related rules.
>>> +$(eval $(call gen-rule-o-from-c-by-name,$(obj)/%,$(obj)/%,$(src-makefile)))
>>> +$(eval $(call gen-rule-i-from-c-by-name,$(obj)/%,$(obj)/%,$(src-makefile)))
>>> +$(eval $(call gen-rule-s-from-c-by-name,$(obj)/%,$(obj)/%,$(src-makefile)))
>>> +$(eval $(call gen-rule-o-from-S-by-name,$(obj)/%,$(obj)/%,$(src-makefile)))
>>> +$(eval $(call gen-rule-d-from-c-by-name,$(obj)/%,$(obj)/%,$(src-makefile)))
>>> +$(eval $(call gen-rule-d-from-S-by-name,$(obj)/%,$(obj)/%,$(src-makefile)))
>>> +$(eval $(call gen-rule-i-from-S-by-name,$(obj)/%,$(obj)/%,$(src-makefile)))
>> Hmm, why not pulled from rules.mk (or added $(src-makefile) there)?
>> Where implicits expand:
>>> $(eval $(call gen-rule-o-from-c-by-name,%,%))
>>> $(eval $(call gen-rule-i-from-c-by-name,%,%))
> 
> these implicit rules actually redundant, I'll drop them out.

When?



More information about the CRIU mailing list