[CRIU] [PATCH 0/5] collect all pid-s in rbtree (v4)

Andrew Vagin avagin at virtuozzo.com
Mon Mar 21 10:59:17 PDT 2016


On Thu, Mar 17, 2016 at 04:02:47PM +0300, Pavel Emelyanov wrote:
> Applied with a manual fix in patch #3:
> 
> > @@ -384,9 +386,63 @@ static int prepare_pstree_for_shell_job(void)
> >  	max_pid = max((int)current_sid, max_pid);
> >  	max_pid = max((int)current_gid, max_pid);
> >  
> > +	if (lookup_create_item(current_sid))
> > +		return -1;
> > +	if (lookup_create_item(current_gid))
> > +		return -1;
> > +
> >  	return 0;
> >  }
> 
> Presumably these if-s should return -1 on lookup_create_item ret
> value being NULL.

Good catch. Thanks!

> 
> -- Pavel


More information about the CRIU mailing list