[CRIU] [PATCH 1/9] nmk: rules.mk -- Drop @CFLAGS_ and @ASFLAGS_ but add ability to bring them via param

Dmitry Safonov dsafonov at virtuozzo.com
Mon Mar 21 06:46:12 PDT 2016


On 03/21/2016 04:41 PM, Cyrill Gorcunov wrote:
> On Mon, Mar 21, 2016 at 04:34:26PM +0300, Dmitry Safonov wrote:
>>>> I mean, currently they are used for expanding rules inside nmk;
>>>> in normal makefiles, you use CFLAGS/AFLAGS for objects, but
>>>> it's not expected to meet some gen-rule-* there (where one needs
>>>> some gen-rule- outside nmk, it seems to be custom rule, not
>>>> a basic as .c file to .o)
>>> Not sure I follow. Could you please describe what you propose?
>>> Initially I thought of passing additional flags via 4th parameter
>>> but then ended up with $(@F) just like kernel does. You wanna import
>>> rules.mk into build.mk, or what?
>> No-no, I like this $(@F) way, as you did.
>> I meant only that no one uses gen-rule-*-from-*-by-name outside
>> nmk (with $(call gen-rule-*)). So I expected to see it here, in nmk
>> patches.
> Ah. They are used in "Make process depend on Makefile itself"
> patch. Once Pavel merge this series I'm open to cleanup
> procedure, so patches are welcome.
Yeah, I was there on fourth parameter, that's not used
on this patches. And as rules aren't useable outside, so
I haven't saw the reason in a new parameter.
But you described that you need it, so ok.

-- 
Regards,
Dmitry Safonov



More information about the CRIU mailing list