[CRIU] [PATCH 1/9] nmk: rules.mk -- Drop @CFLAGS_ and @ASFLAGS_ but add ability to bring them via param

[Dmitry Safonov]

On 03/21/2016 04:31 PM, Cyrill Gorcunov wrote:
> On Mon, Mar 21, 2016 at 04:16:32PM +0300, Dmitry Safonov wrote:
>> On 03/21/2016 03:12 PM, Cyrill Gorcunov wrote:
>>> Both are never worked, we need to pass them as explicit parameter.
>> So, you didn't use forth parameter for gen-rule-* in this patches,
>> how it supposed to be used?
> For a while -- they are gonna be unused. I probably drop them
> off once I manage with hostprog mode.
Ok
>
>> I mean, currently they are used for expanding rules inside nmk;
>> in normal makefiles, you use CFLAGS/AFLAGS for objects, but
>> it's not expected to meet some gen-rule-* there (where one needs
>> some gen-rule- outside nmk, it seems to be custom rule, not
>> a basic as .c file to .o)
> Not sure I follow. Could you please describe what you propose?
> Initially I thought of passing additional flags via 4th parameter
> but then ended up with $(@F) just like kernel does. You wanna import
> rules.mk into build.mk, or what?
No-no, I like this $(@F) way, as you did.
I meant only that no one uses gen-rule-*-from-*-by-name outside
nmk (with $(call gen-rule-*)). So I expected to see it here, in nmk
patches.

-- 
Regards,
Dmitry Safonov