[CRIU] [PATCH 3/9] nmk: rules.mk -- Add per-obj flags

Cyrill Gorcunov gorcunov at gmail.com
Mon Mar 21 05:28:10 PDT 2016


On Mon, Mar 21, 2016 at 03:26:25PM +0300, Cyrill Gorcunov wrote:
> On Mon, Mar 21, 2016 at 03:22:43PM +0300, Dmitry Safonov wrote:
> > On 03/21/2016 03:12 PM, Cyrill Gorcunov wrote:
> > >From: Cyrill Gorcunov <gorcunov at gmail.com>
> > >
> > >Signed-off-by: Cyrill Gorcunov <gorcunov at gmail.com>
> > >Signed-off-by: Cyrill Gorcunov <gorcunov at openvz.org>
> > Small notice, to be sure:
> > >---
> > >  scripts/nmk/scripts/rules.mk | 4 ++--
> > >  1 file changed, 2 insertions(+), 2 deletions(-)
> > >
> > >diff --git a/scripts/nmk/scripts/rules.mk b/scripts/nmk/scripts/rules.mk
> > >index 04c9a7e49547..e69de0b00e90 100644
> > >--- a/scripts/nmk/scripts/rules.mk
> > >+++ b/scripts/nmk/scripts/rules.mk
> > >@@ -3,11 +3,11 @@ ifndef ____nmk_defined__rules
> > >  #
> > >  # Accumulate common flags.
> > >  define nmk-ccflags
> > >-        $(CFLAGS) $(ccflags-y)
> > >+        $(CFLAGS) $(ccflags-y) $(CFLAGS_$(@F))
> > >  endef
> > >  define nmk-asflags
> > >-        $(CFLAGS) $(ASFLAGS) $(asflags-y)
> > >+        $(CFLAGS) $(ASFLAGS) $(asflags-y) $(AFLAGS_$(@F))
> > AFLAGS_ is deliberate or a typo?
> 
> Yes, took it from kernel code.
>

I suspec we need to use $(AFLAGS) instead of $(ASFLAGS) here,
just like kernel does. So ASFLAGS was a typo in first place.

 
> > >  endef
> > >  #
> > 
> > 
> > -- 
> > Regards,
> > Dmitry Safonov
> > 
> 
> 	Cyrill

	Cyrill


More information about the CRIU mailing list