[CRIU] dumping not possible on Fedora 23 with criu-dev (autofs???)

[Adrian Reber]

On Thu, Mar 17, 2016 at 03:46:30PM +0100, Stanislav Kinsburskiy wrote:
> 17.03.2016 15:39, Pavel Emelyanov пишет:
> >On 03/17/2016 05:31 PM, Stanislav Kinsburskiy wrote:
> >>Hi,
> >>
> >>As error message says, kernel is too old: autofs options doesn't have
> >>"pipe_ino=" option.
> >>Autofs kernel patch was merged to linux next:
> >>https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/fs/autofs4/inode.c?id=c83aa55d0bb7ec5b07fdf2346af66bc33ba3cb3d
> >CRIU should work on 3.11, including the default run of the tests.
> 
> Please, try to apply this hunk:
> 
> diff --git a/criu/autofs.c b/criu/autofs.c
> index 1c7c126..606e744 100644
> --- a/criu/autofs.c
> +++ b/criu/autofs.c
> @@ -70,8 +70,8 @@ int autofs_parse(struct mount_info *pm)
>         free(opts);
> 
>         if (pipe_ino == AUTOFS_OPT_UNKNOWN) {
> -               pr_err("Failed to find pipe_ino option (old kernel?)\n");
> -               return -1;
> +               pr_warn("Failed to find pipe_ino option (old kernel?)\n");
> +               return 0;
>         }
> 
>         return autofs_gather_pipe(pipe_ino);

With this I can dump processes again:

(00.005339) 	type autofs source systemd-1 mnt_id 17 s_dev 0x11 / @ ./proc/sys/fs/binfmt_misc flags 0x300000 options fd=42,pgrp=1,timeout=0,minproto=5,maxproto=5,direct
(00.005343) Warn  (autofs.c:75): Failed to find pipe_ino option (old kernel?)
(00.005350) mnt: Building mountpoints tree

Works for me.

		Adrian

> >>All the best,
> >>Stanislav Kinsburskiy
> >>
> >>17.03.2016 15:28, Pavel Emelyanov пишет:
> >>>Stas in Cc.
> >>>
> >>>Stas, please, help.
> >>>
> >>>On 03/17/2016 05:21 PM, Adrian Reber wrote:
> >>>>I currently get the following error on Fedora 23:
> >>>>
> >>>>(00.005285) 	type autofs source systemd-1 mnt_id 17 s_dev 0x11 / @ ./proc/sys/fs/binfmt_misc flags 0x300000 options fd=42,pgrp=1,timeout=0,minproto=5,maxproto=5,direct
> >>>>(00.005289) Error (autofs.c:75): Failed to find pipe_ino option (old kernel?)
> >>>>(00.005291) Error (proc_parse.c:1388): Failed to parse FS specific data on ./proc/sys/fs/binfmt_misc
> >>>>(00.005302) Error (mount.c:1908): mnt: Can't parse 19590's mountinfo
> >>>>(00.005305) Unlock network
> >>>>(00.005308) Unfreezing tasks into 1
> >>>>(00.005309) 	Unseizing 19585 into 1
> >>>>(00.005317) Error (cr-dump.c:1606): Dumping FAILED.
> >>>>
> >>>>
> >>>>As there is the question of an too old kernel, the version I am running
> >>>>is 4.4.3-300.fc23.x86_64
> >>>>
> >>>>Doing the following 'fixes' this problem:
> >>>>
> >>>>    systemctl stop proc-sys-fs-binfmt_misc.automount
> >>>>
> >>>>
> >>>>		Adrian