[CRIU] [PATCH 0/3] check: Fix legacy prctl checks

[Pavel Emelyanov]

On 03/14/2016 08:39 PM, Saied Kazemi wrote:
> While you are it, shouldn't pr_msg() calls when reporting an error be replaced with
> pr_err()?  We have a mix of these calls which doesn't look right to me.  For example:
> 
> pr_err("fdinfo doesn't contain the mnt_id field\n");
> pr_msg("/proc/<pid>/timers file is missing.\n");

Hm... Probably yes. How about this rule of a thumb to decide which should be _msg
and which _err -- if the message is explaining the check's summary, it should be
_msg, if it's just error from glibc call -- it should be _err?

> --Saied
> 
> 
> 
> On Mon, Mar 14, 2016 at 1:56 AM, Cyrill Gorcunov <gorcunov at gmail.com <mailto:gorcunov at gmail.com>> wrote:
> 
>     On Mon, Mar 14, 2016 at 11:31:02AM +0300, Pavel Emelyanov wrote:
>     > When the PR_SET_MM_MAP_SIZE is not supported (kernels prior to 3.17)
>     > we try to check for older API, but there's a set of bugs in there.
>     >
>     > This set fixes them all (I hope).
>     Acked-by: Cyrill Gorcunov <gorcunov at openvz.org <mailto:gorcunov at openvz.org>>
> 
>     Thank you!
> 
>