[CRIU] [PATCH] cr-check: Inspect errno of prctl calls

Filipe Brandenburger filbranden at google.com
Mon Mar 14 10:04:38 PDT 2016


On Mon, Mar 14, 2016 at 9:45 AM, Laurent Dufour
<ldufour at linux.vnet.ibm.com> wrote:
>>> Printing ret would be not informative, please, print errno instead.
>>
>> Ah good catch! I hadn't noticed that, will update that now as well.
>
> I think it would be even more user friendly to print the associated
> error message instead of the errno value, isn't it ?

Yes... In fact I'm replacing this one with %m and adding %m to all the
others where there's a relevant errno... I noticed about two usages of
%m elsewhere, so I hope that approach is OK (let me know if you prefer
an explicit %s with a strerror(errno) instead.)

Cheers,
Filipe


More information about the CRIU mailing list