[CRIU] [PATCH] cr-check: Inspect errno of prctl calls
Filipe Brandenburger
filbranden at google.com
Mon Mar 14 09:39:52 PDT 2016
Hi Pavel,
On Mon, Mar 14, 2016 at 1:44 AM, Pavel Emelyanov <xemul at virtuozzo.com> wrote:
>> + if (ret < 0) {
>> + if (errno == -EPERM)
>
> errno-s contain positive codes.
Yes I realized that after sending the patch... I also found other
parts where it's still checking "ret" instead of "errno" so I started
working on a more thorough fix. Will send you an updated patch
shortly.
>> pr_msg("prctl: PR_SET_MM_EXE_FILE is not supported (%d)\n", ret);
>
> Printing ret would be not informative, please, print errno instead.
Ah good catch! I hadn't noticed that, will update that now as well.
Cheers,
Filipe
More information about the CRIU
mailing list