[CRIU] [PATCH 1/2] zdtm.py: add option --ignore-fails

Pavel Emelyanov xemul at virtuozzo.com
Wed Mar 9 09:58:36 PST 2016


On 03/09/2016 08:34 PM, Andrew Vagin wrote:
> On Wed, Mar 09, 2016 at 12:45:13PM +0300, Pavel Emelyanov wrote:
>> On 03/05/2016 01:49 AM, Andrew Vagin wrote:
>>> On Thu, Mar 03, 2016 at 06:13:15PM +0300, Sergey Bronnikov wrote:
>>>> Introduce an option --ignore-fails to make ability to run all planned tests and
>>>> ignore failed tests.
>>>>
>>>
>>> Here is a very similar functionality:
>>> [RFC PATCH 02/21] zdtm: zdtm.py: add --keep-going and --log-failures options 
>>
>> The --keep-going is the same as --ignore-fails, yes :) Ivan's version
>> was sent earlier, but we expect him to split the patch. So the question
>> to him -- will he re-send the --ignore-failures only patch, or is he OK
>> if I commit Sergey's version?
>>
>>> Will a report contains images and logs for each failed test?
>>
>> Looks like no, but I don't think that this blocks TAP report generation.
>> Does it?
> 
> This patch isn't about TAP report generation.
> I don't know why do we need funtionality which is useless for us.
> 
> This functionality is useless without reports, because we will not be
> able to investigate fails.
> 
> I really don't understand why we spend time to discuss about this.

Sergey, Andrey's point is that the --ignore-fail option works, but is
incomplete when we specify the --report one. More exactly -- the report/
dir would only contain logs for the last failed test.

Would you send patch #3 that fixes the --report and --ignore-fails options
working together?

-- Pavel



More information about the CRIU mailing list