[CRIU] [RFC PATCH 17/21] zdtm: add the multi-test launcher

Cyrill Gorcunov gorcunov at gmail.com
Wed Mar 9 04:30:36 PST 2016


On Wed, Mar 09, 2016 at 02:55:14PM +0300, Pavel Emelyanov wrote:
> On 03/09/2016 01:52 PM, Cyrill Gorcunov wrote:
> > On Wed, Mar 09, 2016 at 01:33:16PM +0300, Pavel Emelyanov wrote:
> >>>
> >>> The only case when we use threads is when some of tests want to run a
> >>> busy loop during C/R. In this case we spawn a thread (using clone(), not
> >>> pthreads) for each such test. After C/R we join all threads and do
> >>> verification in the usual sequential mode.
> >>
> >> Andrey, Cyrill, please, share your thoughts -- the approach here it
> >> to hijack the compiled test binaries and manually jump the code around
> >> them. Instead of patching the test .c-s to prepare them for being
> >> launched as (at least) .so-s. Which way would be more preferred?
> > 
> > I don't understand why we need this at all. What's the point of
> > having this multi-test launcher? What is the problem with running
> > tests one by one?
> 
> :D That's another question. Briefly -- the plan is not only to test
> criu with tons of atomic tests, but also with all possible atomic
> combinations.
> 
> But my original question still stands.

Jumping insode compiled binaries always harder than patching tests.
So i would vote for C patching. But won't agrue against binary
hijacking, it simply harder. So I don't have strong opinion here.


More information about the CRIU mailing list