[CRIU] [RFC PATCH 06/21] zdtm: reuse criu's compiler.h

[Ivan Shapovalov]

On 2016-03-09 at 14:37 +0300, Cyrill Gorcunov wrote:
> On Wed, Mar 09, 2016 at 02:24:14PM +0300, Ivan Shapovalov wrote:
> > 
> > > 
> > > Ideally we don't. We've been planning to move zdtm to
> > > nmk engine and reuse some headers from criu itself
> > > since they are shipped together anyway. But when it
> > > will be done... I don't know yet.
> > Hmm... did not understand. So we are planning to reuse many criu/
> > headers in the future, but reusing just compiler.h for the time
> > being
> > is not acceptable?
> We either should use as much as possible including nmk engine,
> atomics and such in zdtm in one pass or should not intersect
> at all, otherwise it will be a mess -- some headers from
> criu, something from zdtm internals. I think the best way
> is to keep the code separated for a while (and use own
> compiler.h copy, even via simple symlink) but then merge
> code together.

FTR, in this patch reusing is done via a symlink. I don't add
../../criu/include to includepath.

--
Ivan Shapovalov / intelfx /

> 
> Though I would wait for Andrew's feedback. Andrew?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part
URL: <http://lists.openvz.org/pipermail/criu/attachments/20160309/e5d41241/attachment.sig>