[CRIU] [PATCH] LXC WebUI Support

[Adrian Reber]

On Wed, Jun 29, 2016 at 02:20:19PM -0400, Arthur Lockman wrote:
> From: Arthur Lockman <hello at rthr.me>
> 
> Adds support for migrating LXC containers with the p.haul WebUI. It uses the checkpoint functionality in LXC and rsync to migrate and restart the containers on different hosts.
> 
> Signed-off-by: Arthur Lockman <alockman at redhat.com>
> ---
>  README.md                 |  7 +++-
>  phaul/criu_cr.py          |  4 +-
>  phaul/criu_req.py         |  4 +-
>  phaul/iters.py            | 44 +++++++++++++---------
>  phaul/p_haul_vz.py        | 58 ++++++++++++++++++++++++++++
>  webgui/p_haul_web_gui.py  | 36 ++++++++++++++++++
>  webgui/procs.py           |  7 ++++
>  webgui/static/criugui.css | 18 ++++++++-
>  webgui/static/migrate.js  | 96 +++++++++++++++++++++++++++++++++++++++--------
>  webgui/static/pstree.js   | 47 +++++++++++++----------
>  10 files changed, 261 insertions(+), 60 deletions(-)

Thanks for working on this Arthur. The patch, however, needs some work.

Please try to create separate patches for the different code parts your
are changing with detailed commit messages why you are changing it.

It is for example not clear why your are changing the VZ files, but no
changes to the LXC files are made.

With different parts I would expect something like, first the LXC
support in p.haul, then the necessary changes in the webgui and as the
last step the CSS and JS changes (or maybe switch the last steps,
whatever makes more sense).

Thanks for bringing the README up to date, but that could also be a
separate patch.

Also, the webgui currently directly calls the lxc commands and rsync.
The whole migration should be done using p.haul. p.haul, theoretically,
already knows how to migrate LXC container and the necessary steps to
migrate the container's file system. The webgui should only use p.haul
for necessary steps.

So splitting this patch into smaller patches with more detailed
description should make reviewing much simpler.

		Adrian
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 811 bytes
Desc: not available
URL: <http://lists.openvz.org/pipermail/criu/attachments/20160630/c835352a/attachment.sig>