[CRIU] [PATCH] Fix dumping of /proc folder

[Andrei Tuicu]

Resent it with more verbose changelog. Thanks for the review! :)

Andrei

2016-06-28 11:51 GMT+03:00 Cyrill Gorcunov <gorcunov at gmail.com>:

> On Tue, Jun 28, 2016 at 11:30:21AM +0300, Andrei Tuicu wrote:
> >    Hi, Cyrill,
> >    I did not go that far... I looked at the other lines that handle files
> >    under /proc and I didn't see anything special being done about those.
> The
> >    only problem is that criu returns error code for the /proc folder
> itself,
> >    due to what I think is a minor bug. As it is now, if a process does
> >    fopen("/proc", "r"), criu will fail to dump it and I found that a
> little
> >    odd since it has no problem with files/folders that are under /proc.
> >    If I understand correctly what you are saying, then procfs would not
> be
> >    mounted in /proc, but instead in some /path/to/proc, as seen by the
> >    process, right? In that case then the code might need other patches to
> >    handle that.
>
> I meant the case where completely new file tree created (say inside
> container)
> and such processes lives in own /, /proc and etc.
>
> Actually after thinking more I think the patch is correct. Thank you!
> But please make more verbose changelog.
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openvz.org/pipermail/criu/attachments/20160628/82608970/attachment.html>