[CRIU] [PATCHv2 07/30] parasite-head-32: fix cmd & args load
Cyrill Gorcunov
gorcunov at gmail.com
Mon Jun 27 10:53:53 PDT 2016
On Fri, Jun 24, 2016 at 06:08:12PM +0300, Dmitry Safonov wrote:
> Seems like, offset was broken. And it had typo: leal -> movl,
> as cmd parameter is int and in parasite_service()
> Fixed - loads good now.
>
> Cc: Cyrill Gorcunov <gorcunov at openvz.org>
> Signed-off-by: Dmitry Safonov <dsafonov at virtuozzo.com>
> ---
> criu/arch/x86/parasite-head-32.S | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/criu/arch/x86/parasite-head-32.S b/criu/arch/x86/parasite-head-32.S
> index cafbe8115bf1..132d912bba86 100644
> --- a/criu/arch/x86/parasite-head-32.S
> +++ b/criu/arch/x86/parasite-head-32.S
> @@ -14,8 +14,8 @@ ENTRY(__export_parasite_head_start)
> movl %esp, %ebp
> call 1f
> 1: popl %ecx
> -2: leal (__export_parasite_cmd-2b)(%ecx), %eax
> - leal (__export_parasite_args-2b)(%ecx), %edx
> + movl (__export_parasite_cmd-1b)(%ecx), %eax
> + leal (__export_parasite_args-1b)(%ecx), %edx
Mind to explain where it was broken? Why lea doesn't work here?
More information about the CRIU
mailing list