[CRIU] bug in shmem restore?

Mike Rapoport mike.rapoport at gmail.com
Thu Jun 23 01:31:04 PDT 2016


Hi,

I've been looking into reducing use of page-read  internals outside
the page-read.c and found something that seems really weird.

If auto_dedup is enabled, the restore_shmem_content punches a hole in
the  pagemap image, but it never tries to read anything from the
parent image. Moreover, open_page_read_at does not even bother to open
parent image in case it opens shared memory image.

If I understand correctly, if the hole is really punched, calling
restore next time on the same set of images will fail.

Am I missing something?

-- 
Sincerely yours,
Mike.


More information about the CRIU mailing list