[CRIU] [PATCHv1 04/26] sigframe: prepare macro helpers for two sigframes

Dmitry Safonov dsafonov at virtuozzo.com
Thu Jun 16 06:40:42 PDT 2016


On 06/16/2016 04:34 PM, Laurent Dufour wrote:
> On 16/06/2016 12:53, Dmitry Safonov wrote:
>> As on x86 compat/native sigframe differ, I need to generalize/modify
>> sigframe macro helpers having in mind:
>> - SIGFRAME_OFFSET differ between native/compat tasks, so it takes
>>   sigframe parameter now, which will be used in following patches
>>   (also renamed it in RT_SIGFRAME_OFFSET to complement other macros)
>> - RT_SIGFRAME_FPU is now pointer, because each caller takes result's
>>   address with &RT_SIGFRAME_FPU(...)
>> - sigreturn_prep_fpu_frame now takes rt_sigframe parameter, as
>>   address of fpu_state pointer on x86 will depend on native/compat
>>   frame type, so I check local sigframe's type and count address
>>   for rsigframe. (See in the very next commit).
>>
>
> Hi Dimitry,

Hi Laurent,

> I've trouble applying your series on top of criu-dev (commit 674583f20cb6).
> I'd like to apply to it and give it a try before stating...
>
> Could you rebase it ?

Could you tell what kind of trouble do you have?
I mean I based it on today criu-dev on the moment of sending,
and now rebased it on mentioned commit 674583f20cb6 without
any conflict.
The same is with criu-patchwork - it applied patches without fails,
afaics: https://zdtm.openvz.org/series/259/

Thanks for giving it a try :)


More information about the CRIU mailing list