[CRIU] [PATCH v4 07/12] criu: page-xfer: add ability to skip writing lazy pages

[Mike Rapoport]

On Thu, Jun 9, 2016 at 4:12 PM, Mike Rapoport <mike.rapoport at gmail.com> wrote:
>>
>> I have a question here -- if page_xfer_dump_pages sends a pagemap the receiver
>> would expect the subsequent pages on the socket, but instead, it _may_ receive
>> next pagemap if the previous one was lazy. How it this handled?
>
> Hmmm. It is not... I think that page-server and, most probably,
> incremental dumps are not compatible with lazy-pages...

As of now :(

>>>                       if (xfer->write_pages(xfer, ppb->p[0], iov->iov_len))
>>>                               return -1;
>>>               }
>>> diff --git a/criu/shmem.c b/criu/shmem.c
>>> index d9dd405..19d5339 100644
>>> --- a/criu/shmem.c
>>> +++ b/criu/shmem.c
>>> @@ -539,7 +539,7 @@ static int dump_pages(struct page_pipe *pp, struct page_xfer *xfer, void *addr)
>>>                       return -1;
>>>               }
>>>
>>> -     return page_xfer_dump_pages(xfer, pp, (unsigned long)addr);
>>> +     return page_xfer_dump_pages(xfer, pp, (unsigned long)addr, true);
>>>  }
>>>
>>>  static int dump_one_shmem(struct shmem_info *si)
>>>
>>
>
>
>
> --
> Sincerely yours,
> Mike.



-- 
Sincerely yours,
Mike.