[CRIU] [PATCH RFC 0/2] page-read: use in-memory PagemapEntry's

Pavel Emelyanov xemul at virtuozzo.com
Tue Jun 7 08:16:02 PDT 2016


On 06/07/2016 03:35 PM, Mike Rapoport wrote:
> On Tue, Jun 07, 2016 at 02:55:30PM +0300, Pavel Emelyanov wrote:
>> pagemap.img-s use bfd engine to cache reads from images. Your
>> patch creates double buffering for them ;)
> 
> Well, yes. But no :)
> The bfd caches raw protobuf data, while the in-memory pagemap caches
> unpacked PagemapEntrie's. There's indeed some duplication, but you anyway
> have to go through 'bread -> unpack' to use pagemap.

Agree :)

>> Any ideas how to handle it?
> 
> We read the entire pagemap and then close the image? ;-)

Oh, do we do this with this set?

-- Pavel



More information about the CRIU mailing list