[CRIU] [PATCH v4 08/17] scripts: spfs-change-mode.sh added

[Pavel Emelyanov]

On 06/02/2016 03:16 PM, Stanislav Kinsburskiy wrote:
> 
> 
> 02.06.2016 13:15, Pavel Emelyanov пишет:
>> On 05/20/2016 02:37 PM, Stanislav Kinsburskiy wrote:
>>> This scripts can be used on restore to switch all the spfs mounts to Stub mode
>>> when all files have been reopened.
>> Why mount and create_file is implemented as some sort of RPC (via socket)
>> but mode switch is script?
>>
> 
> Your question contains of two:
> 
> 1)  "Why mount and create_file is implemented as some sort of RPC?".
> First, only mount is implemented via RPC. File creation is done by CRIU 
> itself.
> Mount request could be implemented by script, but I didn't see, why 
> should I. To mount SPFS some C code is required anyway, so calling a 
> script doesn't simplify the changes from my POW
> 
> 2) Why mode switch was implemented via script?
> Because it allows to avoid additional impact to criu. Otherwise I had to 
> put some explicit SPFS manager callback to source code of criu somewhere 
> around "post-restore" action scripts call.
> Frankly, source code callback solution looks more strict, and I would 
> prefer it to the script.
> If you have nothing against it, I'll implement.

I'd appreciate if any communication between criu and spfs use the same
approach, be it rpc or script.

-- Pavel