[CRIU] [PATCH v3 00/11] lazy-pages: add support for remote pages

Adrian Reber areber at redhat.com
Thu Jun 2 01:42:33 PDT 2016


Hi Mike,

I applied your patches and I am now looking at the details of your
implementation. Just as an early feedback.

		Adrian

On Wed, Jun 01, 2016 at 12:01:33AM +0300, Mike Rapoport wrote:
> From: Mike Rapoport <rppt at linux.vnet.ibm.com>
> 
> Hi,
> 
> This is essentially v2 plus small fix. I'm resending the entire set to see
> if CI fill find some other bugs :)
> 
> v3 changes:
> * fixed initialization of pp->own_iovs, thanks Mr. Jenkins
> 
> v2 changes:
> * added helpers to page-xfer to reduce code duplication
> * modified protocol between dump side page server and lazy pages daemon as
> per Pavel's comments
> * some changes in the way parasite_dump_pages_seized is refactored. There's
> still more to improve here, even without addition of lazy pages support :)
> 
> TODO:
> * refactor page-reader to support random access and remote page reads
> * make lazy-pages non-blocking with respect to #PFs
> * performance imporvements
> 
> Mike Rapoport (11):
>   criu: page-pipe: introduce page_pipe_buf manipulation helpers
>   criu: page_pipe_buf: add PPB_LAZY flag
>   criu: page-pipe: introduce page_pipe_split
>   criu: page-xfer: move code aroud
>   criu: page-xfer: intorduce helpers for sending IOVs
>   criu: page-xfer: add ability to skip writing lazy pages
>   criu: page-xfer: add PS_IOV_GET interface
>   criu: uffd: add --lazy-addr option
>   criu: slightly refactor memory dump to support delaying it
>   criu: page-pipe: add ability to allocate IOVs
>   criu: lazy-pages: enable remoting of lazy pages
> 
>  criu/cr-dump.c                  |   57 +-
>  criu/crtools.c                  |    4 +
>  criu/include/cr_options.h       |    1 +
>  criu/include/mem.h              |    3 +-
>  criu/include/page-pipe.h        |    9 +-
>  criu/include/page-xfer.h        |    4 +-
>  criu/include/parasite-syscall.h |    1 -
>  criu/include/pstree.h           |    1 +
>  criu/mem.c                      |   52 +-
>  criu/page-pipe.c                |  329 ++++++++++--
>  criu/page-read.c                |    2 +-
>  criu/page-xfer.c                | 1116 +++++++++++++++++++++------------------
>  criu/parasite-syscall.c         |    2 +
>  criu/shmem.c                    |    4 +-
>  criu/uffd.c                     |   35 +-
>  15 files changed, 992 insertions(+), 628 deletions(-)
> 
> -- 
> 1.9.1


More information about the CRIU mailing list