[CRIU] Criu-dev fails on helper_zombie_child test

[Pavel Emelyanov]

Hi, Tycho!

Travis reported the failure on this test. Since I've pushed several times
yesterday, I re-checked the today's criu-dev -- it really fails. Would
you take a look, please?


# ./zdtm.py run -t zdtm/static/helper_zombie_child -f ns
=== Run 1/1 ================

================== Run zdtm/static/helper_zombie_child in ns ===================
cc -g -O2 -Wall -Werror -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=0  -iquote ../lib/arch/x86/include -I../lib   helper_zombie_child.c ../lib/libzdtmtst.a ../lib/libzdtmtst.a -o helper_zombie_child
Construct root for zdtm/static/helper_zombie_child
Start test
./helper_zombie_child --pidfile=helper_zombie_child.pid --outfile=helper_zombie_child.out
Run criu dump
Wait for zdtm/static/helper_zombie_child to die for 0.100000
Run criu restore
=[log]=> dump/zdtm/static/helper_zombie_child/40/1/restore.log
------------------------ grep Error ------------------------
(00.040706) Error (criu/cr-restore.c:1104): 66 exited, status=1
(00.040740) Error (criu/cr-restore.c:1989): Restoring FAILED.
------------------------ ERROR OVER ------------------------
########## Test zdtm/static/helper_zombie_child FAIL at CRIU restore ###########



-------- Forwarded Message --------
Subject: 	Broken: xemul/criu#477 (criu-dev - 1744d6e)
Date: 	Thu, 21 Jul 2016 17:20:46 +0000
From: 	Travis CI <builds at travis-ci.org>
To: 	xemul at virtuozzo.com



*xemul / criu <https://travis-ci.org/xemul/criu>* (criu-dev <https://github.com/xemul/criu/tree/criu-dev>)

	Build #477 was broken. <https://travis-ci.org/xemul/criu/builds/146433527> 	
16 minutes and 22 seconds
	*Tycho Andersen* 	1744d6e <https://github.com/xemul/criu/commit/1744d6ecbd9d4b9cae28285d225fbc00853b758d> Changeset → <https://github.com/xemul/criu/compare/71d96671e98e...1744d6ecbd9d>
  	unix: handle unlink failure correctly

Instead of returning, we should revert the cwd as in all the other error
paths.

*** CID 164720: Resource leaks (RESOURCE_LEAK)
/criu/sk-unix.c: 1030 in bind_unix_sk()
1024 goto done;
1025 }
1026 }
1027
1028 if (ui->ue->deleted && unlink((char
*)ui->ue->name.data) < 0) {
1029 pr_perror("failed to unlink %s\n",
ui->ue->name.data);
>>> >>> CID 164720: Resource leaks (RESOURCE_LEAK)
>>> >>> Handle variable "cwd_fd" going out of scope leaks the handle.
1030 return -1;
1031 }
1032 }
1033
1034 if (ui->ue->state != TCP_LISTEN)
1035 futex_set_and_wake(&ui->prepared, 1);

Signed-off-by: Tycho Andersen <tycho.andersen at canonical.com>
CC: Andrew Vagin <avagin at virtuozzo.com>
Acked-by: Andrew Vagin <avagin at virtuozzo.com>
Signed-off-by: Pavel Emelyanov <xemul at virtuozzo.com>

*System message:*

We are investigating jobs not being processed on .org. http://stspg.io/2xuZ

*Want to know about upcoming build environment updates?*

Would you like to stay up-to-date with the upcoming Travis CI build environment updates? We set up a mailing list for you! Sign up here <http://eepurl.com/9OCsP>.

	Documentation <https://docs.travis-ci.com> about Travis CI
For help please join our IRC channel irc.freenode.net#travis <irc://irc.freenode.net/travis>.
Choose who receives these build notification emails in your configuration file <https://docs.travis-ci.com/user/notifications>.

*Would you like to test your private code?*

Travis CI for Private Projects <https://travis-ci.com?utm_source=build_email_footer&utm_campaign=travis-ci.org&utm_medium=email> could be your new best friend!