[CRIU] ✗ travis-ci: failure for c/r non-dev net syctls

[Andrew Vagin]

On Thu, Jul 21, 2016 at 11:36:41AM +0300, Pavel Tikhomirov wrote:
> 
> 
> On 07/20/2016 09:20 PM, Andrew Vagin wrote:
> > On Wed, Jul 20, 2016 at 06:50:57PM +0300, Pavel Tikhomirov wrote:
> > > 
> > > 
> > > On 07/20/2016 06:12 PM, Patchwork wrote:
> > > > == Series Details ==
> > > > 
> > > > Series: c/r non-dev net syctls
> > > > URL   : https://patchwork.criu.org/series/385/
> > > > State : failure
> > > > 
> > > > == Logs ==
> > > > 
> > > > For more details see: https://travis-ci.org/criupatchwork/criu/builds/146126040
> > > 
> > > killed, may be travis has now v4.3-v4.5 kernel? will look tomorrow,
> > > my run was fine https://travis-ci.org/Snorch/criu/builds/146105557
> > 
> > 3.19.0-30-generic #34~14.04.1-Ubuntu SMP
> 
> Obviously the problem is that patchwork branch
> 385(https://github.com/criupatchwork/criu/commits/385) lacks the must-have
> commit dc72792ce349 ("sysctl: append '\0' in sysctl_read_char") from
> criu-dev branch.

It's obvious for you but not for patchwork;). When the validation failed
on criu-dev, patchwork uses the last revision where the validation
passed.

+ python ../scripts/travis-status.py
7c550177b1dd1ff7e84dcc6c540be54db6e7b67c
+ git checkout -f criu-dev-stable
Previous HEAD position was 7c55017... https://zdtm.openvz.org/series/378
HEAD is now at f56568e... pre-dump: handle only seized tasks
+ git clean -dxf
+ ../patchwork/git-pw/git-pw post-result 385 ci.openvz.org pending --url
https://ci.openvz.org/job/CRIU/job/criu-patchwork/478/
Posted result: ci.openvz.org: pending
+ ../patchwork/git-pw/git-pw apply 385
Applying: net/sysctl: c/r all except *.conf.* and *.neigh.*
Applying: zdtm: add irand_range helper and use it in netns-dev test
Applying: zdtm/sysctls: test all net.xxx except conf and neigh
Applying series: c/r non-dev net syctls (rev 1)

so don't blame criupatchwork, he did everythong all right. If you know a
better way, you can describe it here.

> 
> My tests go well on VZ7, F24, travis, so I assume that my patch is alright.
> 
> > 
> > 
> > > 
> > > > 
> > > 
> > > --
> > > Best regards, Tikhomirov Pavel
> > > Software Developer, Virtuozzo.
> > > _______________________________________________
> > > CRIU mailing list
> > > CRIU at openvz.org
> > > https://lists.openvz.org/mailman/listinfo/criu
> 
> -- 
> Best regards, Tikhomirov Pavel
> Software Developer, Virtuozzo.