[CRIU] [PATCH 0/2] C/R of mandatory mountpoints

[Pavel Emelyanov]

On 07/21/2016 05:11 PM, Dmitry Safonov wrote:
> On 07/21/2016 04:56 PM, Pavel Emelyanov wrote:
>> On 07/12/2016 05:51 PM, Dmitry Safonov wrote:
>>> Support mandatory mounted mountpoints with excluseive locks.
>>
>> I doubt one patch is enough :)
> 
> Thanks, I would like to write more patches :)
> 
>> Consider we restore a mand-mounted sb, we mount it with MS_MANDLOCK, then
>> restore a file lock on it, then try to open this file for some other reason.
>> The criu restore would block (or abort with error).
> 
> Ok, I will look where such situations may happen on restore.
> And could you tell where do you expect this can happen?

Nope, I can't just provide exact code-paths. Just nervous about the fact
that this can happen and we have no prof it can not.

>> So either we somehow make full support for mandlocks, or (since we know
>> the problem exists) explicitly abort dumping these guys.
> 
> Hmm, do you think, we should not?
> I mean, yep, mount part is already complicated, so only by that reason?

Yes, to clearly state that "we can't do it, but we will".

-- Pavel