[CRIU] [PATCHv3 2/4] cr-exec: check syscall's number right before injecting it

[Dmitry Safonov]

On 07/07/2016 03:45 PM, Cyrill Gorcunov wrote:
> On Thu, Jul 07, 2016 at 02:51:54PM +0300, Dmitry Safonov wrote:
>> -find_syscall(char *name, __attribute__((unused)) int pid)
>> +find_syscall(char *name, __attribute__((unused)) struct parasite_ctl *ctl)
>>  {
>>  	return find_syscall_table(name, sc_exec_table_32);
>>  }
>
> Take a look into criu/include/compiler.h please
>
> #define NORETURN 		__attribute__((__noreturn__))
> #define __packed 		__attribute__((__packed__))
> #define __used 			__attribute__((__used__))
> #define __maybe_unused 		__attribute__((unused))
> #define __always_unused 	__attribute__((unused))
>
> I think you better put __maybe_unused here.
>

Right, lets use it. Will send v4 shortly.
I think, here is better __always_unused for config-overloaded function.
BTW, we miss __weak definition there.