[CRIU] [PATCHv3 14/30] page-xfer: dump compatible iovec

[Dmitry Safonov]

On 07/05/2016 02:13 PM, Pavel Emelyanov wrote:
> On 07/05/2016 11:25 AM, Andrew Vagin wrote:
>> On Tue, Jun 28, 2016 at 10:24:07PM +0300, Dmitry Safonov wrote:
>>> Change page_xfer_dump_pages the way it could handle compatible iovs.
>>> Separated hole dumping in page_xfer_dump_hole and introduced
>>> iterator function get_iov which will return native iovec,
>>> converting compatible iovec if needed.
>>>
>>> Fixes:
>>> (00.009060) Fetched ack: 7 7 0
>>> (00.009061) Transfering pages:
>>> (00.009062) 	buf 16/16
>>> (00.009063) 	p 0x100008048000 [32841]
>>> (00.009101) Error (page-xfer.c:504): Only 65536 of 17592320561152 bytes have been spliced
>>> (00.009253) page-pipe: Killing page pipe
>>> (00.009263) ----------------------------------------
>>>
>>
>> [root at fc22-vm criu]# ./test/zdtm.py run -t zdtm/static/env00  --pre 2
>> === Run 1/1 ================
>>
>> ========================== Run zdtm/static/env00 in h ==========================
>> Start test
>> ./env00 --pidfile=env00.pid --outfile=env00.out --envname=ENV_00_TEST
>> Run criu pre-dump
>> Run criu pre-dump
>> Run criu dump
>> Run criu restore
>> =[log]=> dump/zdtm/static/env00/24/3/restore.log
>> ------------------------ grep Error ------------------------
>> (00.035223)     24: Error (mem.c:826): Page entry address 400000 outside of VMA 7fffddbcf000-7fffddbd1000
>> (00.035323) Error (cr-restore.c:1885): Restoring FAILED.
>> ------------------------ ERROR OVER ------------------------
>> ################# Test zdtm/static/env00 FAIL at CRIU restore ##################
>> ##################################### FAIL #####################################
>>
>> https://github.com/xemul/criu/issues/185
>
> The pagemap image for test becomes unsorted.

Yes, thanks, I have reproduced and also found image unsorted.
Working on fix.