[CRIU] [PATCH] build: nmk -- Filter out -Wl flags from linking builtin targets

[Dmitry Safonov]

On 07/01/2016 02:10 PM, Cyrill Gorcunov wrote:
> On Fri, Jul 01, 2016 at 02:05:37PM +0300, Dmitry Safonov wrote:
>> On 06/30/2016 06:46 PM, Cyrill Gorcunov wrote:
>>> Tycho reported that Debian uses custom LDFLAGS to
>>> build criu, this flag get propagated into built-in
>>> targets where we use $(LD) instead causing build
>>> procedure to interrupt
>>>
>>> |  LINK     arch/x86/syscalls.built-in.o
>>> | ld: unrecognized option '-Wl,-Bsymbolic-functions'
>>> | ld: use the --help option for usage information
>>> | /«PKGBUILDDIR»/scripts/nmk/scripts/build.mk:141: recipe for target 'arch/x86/syscalls.built-in.o' failed
>>>
>>> Lets make maintainers life easier and filter
>>> out the flags we know never accepted by $(LD).
>>>
>>> Reported-by: Tycho Andersen <tycho.andersen at canonical.com>
>>> Tested-by: Tycho Andersen <tycho.andersen at canonical.com>
>>> Signed-off-by: Cyrill Gorcunov <gorcunov at openvz.org>
>>
>> Should we pass those parameters to ld without -Wl, or silently ignore
>> them like in this patch?
>> Maybe ignore for simplicity for now. Anyway, anyone who want override
>> LDFLAGS may pass them without -Wl, so they wouldn't be filtered.
>>
>> Reviewed-by: Dmitry Safonov <dsafonov at virtuozzo.com>
>
> I think we better ignore, criu is special, and using nmk
> implies that if you need some parameters for builtin
> targets -- use ldflags-y.
>

Well, I also think so.