[CRIU] [PATCH CRIU 0/4] mount: fixes for slave mounts

Andrew Vagin avagin at gmail.com
Thu Jan 28 15:01:56 PST 2016


On Wed, Jan 27, 2016 at 05:13:54PM +0300, Pavel Emelyanov wrote:
> On 01/20/2016 06:42 PM, Pavel Tikhomirov wrote:
> > Main problem I was trying to solve that migrating Virtuozzo container
> > some slave mounts which at the same time were shared, become shared
> > only. They lost "master:%d" in /proc/self/mountinfo output. It was
> > because we made those mounts private before making them slave.
> > 
> > https://jira.sw.ru/browse/PSBM-42829
> > 
> > Pavel Tikhomirov (4):
> >   mount: get over autodetected mounts in search for widest shared peer
> >   mount: do not make external mounts to be private if not needed
> >   mount: do not mark mount internaly shared if match is master not share
> >   mount: if mount should have master we must not set mount private
> > 
> >  mount.c | 26 ++++++++++++++++++++++----
> >  1 file changed, 22 insertions(+), 4 deletions(-)
> > 
> 
> Andrey, Tycho, what do we do with this set? Do you Ack all patches of
> it, want Pavel to rework/fix or is it up to ... the maintainer :) ?

I think we need to commit the second version of the second patch. It
looks correct. I don't understand other patches.

We can't use --ext-mount-map auto for Virtuozzo containers, because we
have a "copy" of a container mount tree on the host side (/vz/root/101)
and it exists only when a container is running.
> 
> -- Pavel
> _______________________________________________
> CRIU mailing list
> CRIU at openvz.org
> https://lists.openvz.org/mailman/listinfo/criu


More information about the CRIU mailing list